refactor: make send_keys a generic key sender, drop hardcoded Enter#18
Merged
MSmaili merged 1 commit intoMSmaili:mainfrom Mar 1, 2026
Merged
refactor: make send_keys a generic key sender, drop hardcoded Enter#18MSmaili merged 1 commit intoMSmaili:mainfrom
MSmaili merged 1 commit intoMSmaili:mainfrom
Conversation
Owner
|
I agree with this implementation, and this can be merged when you are ready. It makse much more sense. |
Owner
|
Please resolve the conflicts, and we can merge this @jxyyz |
- Accept string|string[] instead of single string - Callers now explicitly pass "Enter" where needed - Replace mock with real implementation in tests
jxyyz
force-pushed
the
fix/send-keys-signature
branch
from
8d9e240 to
a2a3e82
Compare
Contributor
Author
|
Hi @MSmaili. Conflict resolved. I'll also get back to you regarding the other open issues/PRs, as I haven't been active lately. |
MSmaili
approved these changes
Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves related issue #16
Creating as draft, because I want to manually test those changes for some time, before creating final PR to upstream.